Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to cloud, hamburger menu, refactors #6

Merged
merged 15 commits into from
Jun 7, 2023
Merged

feat: migrate to cloud, hamburger menu, refactors #6

merged 15 commits into from
Jun 7, 2023

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Jun 1, 2023 •
edited
Loading

What does this PR do?

  • Use consistent layout across pages
  • Update packages
  • Migrate to appwrite cloud
  • Use 'author' team for blog creation security
  • Implement hamburger menu on mobile
  • CSS style fixes
  • Miscellaneous refactoring

Test Plan

Manuel

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Jun 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
demos-for-astro-example-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 0:35am

@loks0n loks0n changed the title Dev feat: migrate to cloud, hamburger menu, refactors Jun 1, 2023
TGlide
TGlide reviewed Jun 1, 2023
View reviewed changes
example-blog/src/components/Comments.astro Outdated Show resolved Hide resolved
example-blog/src/components/Comments.astro Outdated Show resolved Hide resolved
example-blog/src/components/Header.astro Outdated Show resolved Hide resolved
example-blog/src/lib/appwrite.ts Outdated Show resolved Hide resolved
example-blog/src/lib/appwrite.ts Outdated Show resolved Hide resolved
example-blog/src/pages/account/index.astro Outdated Show resolved Hide resolved
gewenyu99
gewenyu99 suggested changes Jun 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@gewenyu99
Copy link

Screen.Recording.2023-06-01.at.10.02.56.AM.mov

Another note, AH MY EYES :P

For some reason, switching between pages sometimes toggles theme

@gewenyu99
Copy link

Can we also not view comments until we login? 🤔

@loks0n
chore: oxford comma
7ceacd7 
Co-authored-by: Vincent (Wen Yu) Ge <wenyu1999@hotmail.com>
@loks0n
Copy link
Member Author

loks0n commented Jun 1, 2023

Can we also not view comments until we login? 🤔

Yeah. I considered changing it. What do you think?

@gewenyu99
Copy link

Can we also not view comments until we login? 🤔

Yeah. I considered changing it. What do you think?

Let's do: You can read but not post

@loks0n
Copy link
Member Author

loks0n commented Jun 5, 2023

Screen.Recording.2023-06-01.at.10.02.56.AM.mov
Another note, AH MY EYES :P

For some reason, switching between pages sometimes toggles theme

This page wasn't using SiteLayout, fixed now

@loks0n loks0n requested a review from gewenyu99 June 5, 2023 15:14
gewenyu99
gewenyu99 approved these changes Jun 5, 2023
View reviewed changes
Copy link

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

Suggestion, but optional, should we add a divider and heading to make it more obvious that the comment section are comments, right now they just look like a part of the post without clear division in the UI.

@loks0n loks0n merged commit 59f2152 into main Jun 7, 2023
@stnguyen90 stnguyen90 mentioned this pull request Jul 22, 2023
Merged
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewenyu99 gewenyu99 gewenyu99 approved these changes

@TGlide TGlide TGlide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loks0n @gewenyu99 @TGlide